obd Issue Tracker Rss Feed

Closed Issue: Unhandled AggregateException when OBD connection fails in SkinSelector loaded event [15139]

peekb — Fri, 11 May 2012 22:09:15 GMT

SkinSelector.xaml.cs, line 44 creates a task to connect to the COM port asynchronously, within a try-catch block. However, if the Connect call fails it will happen in the context of the Task, not the loaded event so the AggregateException will not be caught and an unhandled IOException will kill the process.

Recommend using a continuation instead:

Task.Factory.StartNew(() => _obd.Connect(Properties.Settings.Default.ComPort, Properties.Settings.Default.Baud, ObdDevice.UnknownProtocol, true))
.ContinueWith(action =>
{
Exception ex = action.Exception.Flatten();

SetMessage("Unable to connect to OBD device: " + ex.Message);
Debug.WriteLine(ex);
}, TaskContinuationOptions.OnlyOnFaulted);
Comments:

Change checked into source control.

Commented Issue: Unhandled AggregateException when OBD connection fails in SkinSelector loaded event [15139]

peekb — Thu, 10 May 2012 18:29:43 GMT

Good call. I'll see if I can wedge it in there. Thanks!

Created Issue: Unhandled AggregateException when OBD connection fails in SkinSelector loaded event [15139]

sfiorito — Thu, 10 May 2012 03:38:13 GMT